Hello Stefan
I've checked origin of headers, some of them are self-made, other came from
following places:
1. file rtl8139.c from QEMU codebase
2. /usr/include/netinet/ip6.h from glibc
3. /usr/include/netinet/in.h from glibc
How should we indicate this? Should we add something like:
Portions developed by Free Software Foundation, Inc
Copyright (C) 1991-1997, 2001, 2003, 2006 Free Software Foundation, Inc.
Portions developed by Igor Kovalenko
Copyright (c) 2006 Igor Kovalenko
Is it enough?
Thanks for advice,
Dmitry.
On Wed, Jan 16, 2013 at 5:24 PM, Stefan Hajnoczi <stefa...@gmail.com> wrote:
> On Sat, Jan 12, 2013 at 06:09:44PM +0200, Dmitry Fleytman wrote:
> > diff --git a/eth.c b/eth.c
> > new file mode 100644
> > index 0000000..a591ee5
> > --- /dev/null
> > +++ b/eth.c
> > @@ -0,0 +1,219 @@
> > +/*
> > + * QEMU network structures definitions and helper functions
> > + *
> > + * Copyright (c) 2012 Ravello Systems LTD (http://ravellosystems.com)
> > + *
> > + * Developed by Daynix Computing LTD (http://www.daynix.com)
> > + *
> > + * Authors:
> > + * Dmitry Fleytman <dmi...@daynix.com>
> > + * Tamir Shomer <tam...@daynix.com>
> > + * Yan Vugenfirer <y...@daynix.com>
> > + *
> > + * This work is licensed under the terms of the GNU GPL, version 2 or
> later.
> > + * See the COPYING file in the top-level directory.
> > + *
> > + */
> > +
> > +//#include "hw.h"
>
> Please remove this commented-out line.
>
> > diff --git a/include/qemu/eth.h b/include/qemu/eth.h
> > new file mode 100644
> > index 0000000..b806fb4
> > --- /dev/null
> > +++ b/include/qemu/eth.h
> > @@ -0,0 +1,338 @@
> > +/*
> > + * QEMU network structures definitions and helper functions
> > + *
> > + * Copyright (c) 2012 Ravello Systems LTD (http://ravellosystems.com)
> > + *
> > + * Developed by Daynix Computing LTD (http://www.daynix.com)
> > + *
> > + * Authors:
> > + * Dmitry Fleytman <dmi...@daynix.com>
> > + * Tamir Shomer <tam...@daynix.com>
> > + * Yan Vugenfirer <y...@daynix.com>
> > + *
> > + * This work is licensed under the terms of the GNU GPL, version 2 or
> later.
> > + * See the COPYING file in the top-level directory.
> > + *
> > + */
>
> Please indicate where these header definitions come from and how they
> are licensed.
>
--
Dmitry Fleytman
Technology Expert and Consultant,
Daynix Computing Ltd.
Cell: +972-54-2819481
Skype: dmitry.fleytman
