On Sun, Jan 27, 2013 at 3:50 PM, David Woodhouse <dw...@infradead.org> wrote: > On Sun, 2013-01-27 at 15:14 +0000, Blue Swirl wrote: >> It looks like this duplicates rom_add_file() and fw_cfg_add_file(), so >> I don't see the point. > > Both of those are read-only, surely? The firmware inside the guest can't > use them for non-volatile storage.
Right. But why do we need PV non-volatile storage, instead of normal flash? > > It doesn't duplicate fw_cfg_add_file(); it extends it to allow a > writeable mode too. fw_cfg_add_file() becomes a simple wrapper around > fw_cfg_add_file_writeable(), which actually contains most of the > contents of the original function. OK, however most of the loading logic is now in loader.c and that should not be duplicated either. > > -- > dwmw2 >