On Sat, 26 Jan 2013 16:50:12 +0100 Andreas Färber <afaer...@suse.de> wrote:
> Am 21.01.2013 15:06, schrieb Igor Mammedov: > > Igor Mammedov (5): > > target-i386: print deprecated warning if xlevel < 0x80000000 > > target-i386: replace uint32_t vendor fields by vendor string in > > x86_def_t > > target-i386: remove vendor_override field from CPUX86State > > target-i386: set custom features/properties without intermediate > > x86_def_t > > target-i386: remove setting tsc-frequency from x86_def_t > > I left some comments on 4/5 but applied the remainder of the series to > qom-cpu queue nontheless, as a good preparation for X86CPU subclasses. > > https://github.com/afaerber/qemu-cpu/commits/qom-cpu > > I'd appreciate if you could double-check spelling of commit messages and > restrict them to 76 chars (check `git log` on 80-wide terminal). > Also a reminder that I capitalize the first word of the title after the > topic for consistency and so that it stands out more. ;) I'll make extra checks before posting next patches. > Feel free to complain if I didn't get the difference of the * and - > bullet points on 4/5 for instance. It's not of difference to me. I'll use * in follow-ups. Thanks! > > Thanks, > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- Regards, Igor