Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables

[Gerd Hoffmann]

  Hi,

>  hw/usb/hcd-ehci-sysbus.c |    6 ++++++
>  hw/usb/hcd-ehci.c        |   21 +++++++++++++--------
>  hw/usb/hcd-ehci.h        |   12 ++++++------

> +    s->portscbase = sec->portscbase;
> +    s->portnr = sec->portnr;

These two must be initialized in usb_ehci_pci_initfn too.

Otherwise the patch looks fine.

cheers,
  Gerd