Andreas Färber <afaer...@suse.de> writes: > Hello, > > Am 28.01.2013 23:01, schrieb mrhi...@linux.vnet.ibm.com: >> From: "Michael R. Hines" <mrhi...@us.ibm.com> >> >> >> Signed-off-by: Michael R. Hines <mrhi...@us.ibm.com> >> --- >> Makefile.target | 5 +- >> include/qemu/rdma.h | 249 ++++++++++ >> qemu-rdma.c | 1357 >> +++++++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 1609 insertions(+), 2 deletions(-) >> create mode 100644 include/qemu/rdma.h >> create mode 100644 qemu-rdma.c > > This series is missing a cover letter with explanations, starting with > the acronym and its purpose.
Indeed. A bit of an introduction of what problem the series solves is in order. Can you share performance data with and without RMDA? > Further, the commit messages are lacking > descriptions. Any reason that the code is GPLv2 rather than GPLv2+? I assume copy/paste. Michael, unless you had an explicit reason to use GPLv2 only, we now prefer GPLv2+. Regards, Anthony Liguori > > Regards, > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
