On 02/01/2013 11:28 AM, Laszlo Ersek wrote: > Hello Seiji-san, > > On 02/01/13 15:53, Seiji Aguchi wrote: > >> A logic calculating a time is copied from libvirt, src/util/virtime.c. > >> +static void error_print_timestamp(void) > > Are gmtime() + strftime() unsuitable for some reason?
They are not async-signal safe, so they are not usable in between a fork() and exec*(). Libvirt avoids them because it DOES log information including timestamps in between fork/exec (and prior to writing libvirt's virtime.c, we DID hit cases where libvirt would deadlock a child process due to the non-safe use of a more naive timestamp generator), but I don't know if qemu suffers from the same restriction of when it has anything worth logging. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
