On 02/04/13 16:07, Stefan Hajnoczi wrote: > slirp uses OOB because it implements TCP. I don't think we can drop it.
I considered slirp for that reason, and I did grep the tree for OOB and saw some hits. I didn't track it down but I thought slirp would use lower level sockets (SOCK_RAW?) for the TCP implementation. Ie. it would provide OOB but not depend on it (because OOB doesn't make sense at the IP level; the urgent pointer is in the TCP header). Anyway it's not important. > Yes, it's an interesting feature of pollfds_poll(). It does not clobber > revents. This means you can apply additional *_poll()-style functions > before calling pollfds_poll(). I thought this was neat but I guess we > can drop it. Ah I didn't realize that. I think a comment should be enough, should you respin it. > Thanks for the review. If I need to respin I'll address comments. It's more clear now, thanks! Laszlo
