On Wed, Feb 06, 2013 at 01:31:38PM +0100, Benoît Canet wrote: > /* XXX: cache several refcount block clusters ? */ > -static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs, > +int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
Public functions are prefixed with qcow2_. At this point in the series it's also hard to know whether the code which will call into update_refcount() would better be located in block/qcow2-refcount.c, keeping update_refcount() static.