On 02/06/2013 05:32 AM, Benoît Canet wrote: > --- > block/qcow2-dedup.c | 31 +++++++++++++++++++++++++++++++ > block/qcow2.c | 2 ++ > block/qcow2.h | 1 + > 3 files changed, 34 insertions(+) > > diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c > index bbbb1ac..66fb415 100644 > --- a/block/qcow2-dedup.c > +++ b/block/qcow2-dedup.c > @@ -1278,15 +1278,20 @@ static void > qcow2_deduplicate_after_resuming(BlockDriverState *bs) > BDRVQcowState *s = bs->opaque; > uint64_t i; > bool processed; > + bool exit;
Naming local variables that shadow global functions is risky. I don't know if qemu has a policy on being clean under -Wshadow, but this would fail such a policy. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
