On Thu, 7 Feb 2013 15:04:54 -0200 Eduardo Habkost <ehabk...@redhat.com> wrote:
> On Tue, Feb 05, 2013 at 09:39:16PM +0100, Laszlo Ersek wrote: > > Error handling is not changed yet. > > > > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > > The extra parameter seems useless and even misleading (because Error > info won't be set even if the function returns -1) without patch 04/15. > What about squashing both patches together? I suggested him to do it this way as a general rule because it makes it easier to review when the function getting the Error ** argument is called from several other functions. In that case, you'll usually add different error handling to callers and having everything in one big patch makes it just impossible to review. This case is simple, so it doesn't matter much. Although I do think it's easier to review this way.