Re: [Qemu-devel] [PATCH for-1.4 v2 5/6] vl: Drop redundant "parse error" reports

[Luiz Capitulino]

On Fri,  8 Feb 2013 17:17:11 +0100
Markus Armbruster <arm...@redhat.com> wrote:

> qemu_opts_parse() reports the error already, and in a much more useful
> way.
> 
> Signed-off-by: Markus Armbruster <arm...@redhat.com>

Reviewed-by: Luiz Capitulino <lcapitul...@redhat.com>

> ---
>  vl.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/vl.c b/vl.c
> index a8dc73d..73122d8 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3334,7 +3334,6 @@ int main(int argc, char **argv, char **envp)
>                  }
>                  opts = qemu_opts_parse(olist, optarg, 1);
>                  if (!opts) {
> -                    fprintf(stderr, "parse error: %s\n", optarg);
>                      exit(1);
>                  }
>                  break;
> @@ -3350,7 +3349,6 @@ int main(int argc, char **argv, char **envp)
>                  }
>                  opts = qemu_opts_parse(olist, optarg, 1);
>                  if (!opts) {
> -                    fprintf(stderr, "parse error: %s\n", optarg);
>                      exit(1);
>                  }
>  
> @@ -3521,7 +3519,6 @@ int main(int argc, char **argv, char **envp)
>                  olist = qemu_find_opts("machine");
>                  opts = qemu_opts_parse(olist, optarg, 1);
>                  if (!opts) {
> -                    fprintf(stderr, "parse error: %s\n", optarg);
>                      exit(1);
>                  }
>                  optarg = qemu_opt_get(opts, "type");
> @@ -3755,7 +3752,6 @@ int main(int argc, char **argv, char **envp)
>                  }
>                  opts = qemu_opts_parse(olist, optarg, 0);
>                  if (!opts) {
> -                    fprintf(stderr, "parse error: %s\n", optarg);
>                      exit(1);
>                  }
>                  break;