Am 16.02.2013 13:19, schrieb Julio Guerra: > The software reset of a PReP machine should reset the entire system > and not only the processor. It occurs when changing the 7th bit of > port 0092 from 0 to 1. > > Adding a new variable in PReP's sysctrl_t to store the soft reset bit > makes possible to be compliant with PReP specification : > * reset the system when changing soft reset bit from 0 to 1. > * the soft reset bit value is 1 after a soft reset. > * Port 0092 is read/write. > > qemu_system_reset_request() does the required job (calling the reset > handlers) when the software reset is needed. > > reset_irq is no longer needed, the CPU reset (calling ppc_prep_reset) > is called when qemu_system_reset calls every reset handlers. > > Signed-off-by: Julio Guerra <gu...@julio.in <mailto:gu...@julio.in>> > --- > prep.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-)
PReP patches should be directed to the PReP maintainer please. --cccmd="scripts/get_maintainer.pl --nogit-fallback" can do this automatically for you. The patch is HTML-formatted and thus broken. Also the diffstat looks strange (path missing). Please use git-send-email to avoid such issues. Please use "prep: Fix software reset" or so as subject, using an identifying topic based on file name or subsystem and a verb. How did you test this change? Regards, Andreas http://wiki.qemu.org/Contribute/SubmitAPatch https://live.gnome.org/Git/CommitMessages -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg