Re: [Qemu-devel] [PATCH 09/41] migration: flush all data to fd when buffered_flush is called

[Orit Wasserman]

On 02/15/2013 07:46 PM, Paolo Bonzini wrote:
> Including data that resided in the QEMUFile's own buffer.
> 
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
>  migration.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/migration.c b/migration.c
> index 0f3cb5d..609bd7c 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -525,6 +525,8 @@ static ssize_t buffered_flush(MigrationState *s)
>  
>      DPRINTF("flushing %zu byte(s) of data\n", s->buffer_size);
>  
> +    qemu_fflush(s->file);
> +
>      while (s->bytes_xfer < s->xfer_limit && offset < s->buffer_size) {
>          size_t to_send = MIN(s->buffer_size - offset, s->xfer_limit - 
> s->bytes_xfer);
>          ret = migrate_fd_put_buffer(s, s->buffer + offset, to_send);
> 
Reviewed-by: Orit Wasserman <owass...@redhat.com>