Anthony Liguori writes ("Re: [Qemu-devel] [PATCH] Allow AF_UNIX sockets to be disabled on non-Windows"): > Presumably, this is because you're compiling for MiniOS? Why not just > add a _MINIOS define and then add an appropriate #ifndef.
Yes. We'll probably add a MINIOS define, yes (at the moment our tree is too divergent; these patches are an attempt at restoring some semblance of sanity to the Xen situation). But when the existing code says } #ifndef _WIN32 if (strstart(display, "unix:", &p)) { addr = (struct sockaddr *)&uaddr; addrlen = sizeof(uaddr); etc. then changing it to something like #if !(defined(_WIN32) || defined(MINIOS) seems very ugly. The information about whether a host platform supports AF_UNIX should be in one place, and there should be one place to turn the functionality on and off in qemu. slirp already uses NO_UNIX_SOCKETS so I just reused that name, although unfortunately it's still set in two different places. Ian.