Jesse Larrew <jlar...@linux.vnet.ibm.com> writes: > To ensure compatibility between qemu versions, virtio drivers should set > the size of their config structs according to the feature bits that are > set. This should keep the size from changing as new features are introduced > and avoid breaking older drivers. > > [PATCH 1/8] virtio-net: replace redundant config_size field with config_len > [PATCH 2/8] virtio: put struct VirtIOFeature in a header > [PATCH 3/8] virtio: pass host features to driver init functions > [PATCH 4/8] virtio: set config size using host features > [PATCH 5/8] virtio-balloon: fill in the table of feature_sizes > [PATCH 6/8] virtio-serial: fill in the feature table > [PATCH 7/8] virtio-scsi: fill in table of feature sizes > [PATCH 8/8] virtio-blk: fill in the feature table
Breaks the build. There's no good reason for this either. Don't send patches unless you've done a full build (without a --target-list option). CC s390x-softmmu/hw/s390x/s390-virtio-bus.o /home/aliguori/git/qemu/hw/s390x/s390-virtio-bus.c: In function ‘s390_virtio_scsi_init’: /home/aliguori/git/qemu/hw/s390x/s390-virtio-bus.c:203:5: error: too few arguments to function ‘virtio_scsi_init’ In file included from /home/aliguori/git/qemu/hw/s390x/s390-virtio-bus.c:27:0: /home/aliguori/git/qemu/hw/virtio.h:268:15: note: declared here /home/aliguori/git/qemu/hw/s390x/s390-virtio-bus.c:208:5: error: too many arguments to function ‘s390_virtio_device_init’ /home/aliguori/git/qemu/hw/s390x/s390-virtio-bus.c:123:12: note: declared here make[1]: *** [hw/s390x/s390-virtio-bus.o] Error 1 make: *** [subdir-s390x-softmmu] Error 2 Regards, Anthony Liguori
