On Thu, 7 Feb 2013 11:31:08 -0200 Luiz Capitulino <lcapitul...@redhat.com> wrote:
> On Thu, 07 Feb 2013 14:28:33 +0100 > Kevin Wolf <kw...@redhat.com> wrote: > > > Am 07.02.2013 14:15, schrieb Luiz Capitulino: > > > On Thu, 07 Feb 2013 14:12:10 +0100 > > > Kevin Wolf <kw...@redhat.com> wrote: > > >> I think the right solution is to move the bdrv_dev_change_media_cb() > > >> call to those callers of bdrv_close() that actually need it. I haven't > > >> checked it yet in detail, but at the first sight it looks like > > >> eject_device() and do_drive_del() are the only ones that need it. > > >> > > >> Such a change I'd rather move to 1.5, though. Do you think it's > > >> important to get rid of these (admittedly odd) artefacts for 1.4? > > > > > > I don't have any reports of this causing issues to QMP clients, so > > > we can defer to 1.5. Worst case we merge this fix for a stable release. > > > > Okay, then that's the plan. Are you going to send a patch for 1.5 or > > should I make sure to have it somewhere on a todo list? > > I can do it, but not this week. It turns out I couldn't work on it this week, and I'll be off for some time starting Monday next week.
