On 23.02.2013, at 09:13, David Gibson wrote:
> On Fri, Feb 22, 2013 at 05:13:56PM +0100, Alexander Graf wrote:
>> On 12.02.2013, at 03:00, David Gibson wrote:
> [snip]
>>> + } else if (ret < 0) {
>>> + LOG_MMU_STATE(env);
>>> + if (access_type == ACCESS_CODE) {
>>> + switch (ret) {
>>> + case -1:
>>> + env->exception_index = POWERPC_EXCP_ISI;
>>> + env->error_code = 0x40000000;
>>> + break;
>>> + case -2:
>>> + /* Access rights violation */
>>
>> These really should become an enum or defines. Something where the
>> thing we check on tells us what we're checking for without a comment
>> :).
>
> So, I didn't want to introduce an emum or whatever at the same time as
> I was just moving the code around - makes for more chance of
> mistakes. And by the end of the series, I've gotten rid of these
> magic error values anyway, by reporting the exceptions in-line in mmu
> fault handle, so I think it's kind of moot.
I was reviewing the earlier 8 patch set which didn't convert the return values
to inline exception paths yet. The new set looks very nice :)
Alex
