On 02/24/2013 11:18 PM, Dietmar Maurer wrote:
>>> + if (full_read(vmar->fd, vmar->head_data, sizeof(VmaHeader)) !=
>>> + sizeof(VmaHeader)) {
>>> + error_setg(errp, "can't read vma header - %s",
>>> + errno ? strerror(errno) : "got EOF");
>>
>> You're not the first user, but strerror() isn't thread-safe. strerror_r is
>> not
>> necessarily portable (glibc vs. POSIX), and strerror_l isn't yet widely
>> implemented. Should qemu be providing a better interface
>> qemu_strerror() that guarantees thread-safety when converting errno to a
>> string?
>
> I thought I can use g_strerror?g_strerror is not in use in the current qemu code base; but maybe it is indeed the right alternative? I'm asking because I'm not a glib expert. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
