Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c

[Wenchao Xia]

于 2013-2-28 0:22, Kevin Wolf 写道:

Am 27.02.2013 um 17:04 hat Markus Armbruster geschrieben:

Wenchao Xia <xiaw...@linux.vnet.ibm.com> writes:

Signed-off-by: Wenchao Xia <xiaw...@linux.vnet.ibm.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
---
  block.c               |   24 ++++++++++++++++++++++++
  include/block/block.h |    2 ++
  savevm.c              |   22 ----------------------
  3 files changed, 26 insertions(+), 22 deletions(-)

Perhaps savevm.c isn't the best home for snapshot stuff, but I don't
like it in block.c any better.  block.c is already unwieldy, and I'd
like us to try limiting it to core block stuff.

Kevin, Stefan, any ideas?

Take some more snapshot related functions from block.c and move them to
block/snapshot.c?

Kevin

Hi, Stefan
  Do you also agree about adding new file block/snapshot.c?


--
Best Regards

Wenchao Xia