On 03/01/2013 10:38 AM, Eric Blake wrote: >> + error_setg_errno(errp, errno, "Invalid time %ld for overflow", >> + time_ns); > > That wording sounds awkward. Worse, errno is NOT set to anything sane, > so you do NOT want error_setg_errno. And %ld is wrong for int64_t on > 32-bit platforms. How about: > > error_setg(errp, "Time %" PRI64D " is too large", time_ns);
Don't know what I was thinking; there is no PRI64D. I meant PRId64. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
