On 4 March 2013 01:21, Alex Williamson <alex.william...@redhat.com> wrote: > --- a/hw/pci/pcie_port.c > +++ b/hw/pci/pcie_port.c > @@ -28,10 +28,12 @@ void pcie_port_init_reg(PCIDevice *d) > pci_set_word(d->config + PCI_SEC_STATUS, 0); > > /* Unlike conventional pci bridge, some bits are hardwired to 0. */ > +#define PCI_BRIDGE_CTL_VGA_16BIT 0x10 /* VGA 16-bit decode */
Shouldn't this #define be in pci_regs.h with the other PCI_BRIDGE_CTL_* constants? > pci_set_word(d->wmask + PCI_BRIDGE_CONTROL, > PCI_BRIDGE_CTL_PARITY | > PCI_BRIDGE_CTL_ISA | > PCI_BRIDGE_CTL_VGA | > + PCI_BRIDGE_CTL_VGA_16BIT | /* Req, but no alias support yet > */ > PCI_BRIDGE_CTL_SERR | > PCI_BRIDGE_CTL_BUS_RESET); > } thanks -- PMM
