Il 04/03/2013 11:59, Gleb Natapov ha scritto: > > I want to make the ioport configurable in the device, but the PIIX and > > ICH9 (which are what the DSDT is written for) will always use port 0x505. > > But the device is not part of PIIX or ICH9.
So is kvmclock, or kvmvapic. I think it makes sense to add this device to PIIX or ICH9 since it is an ISA device. > It is additional device that > may or may not be present depending on a command line. So what if > someone configures debugcon or debugexit to use this port? I haven't checked if debug{con,exit} will pass the _STA test, but if they do, the user will get a Ctrl-A or respectively an exit of QEMU when the guest panics. What if someone configures debugcon on port 0x3f8? Some guest will use it, some will not. > We can always > blame the users, but I fill that we are making unnecessary compromises. Once we choose an ISA device, where the user has full control of the address space, we already know we'll have to accept compromises. I don't think this compromise is particularly bad: do discovery via ACPI (nice), accept that the user can trick the AML (ugly). Paolo > > You can configure a different iobase for your serial ports, the guest > > can still use them but not discover them via ACPI. This is the same thing. > > Probably we should patch DSDT too when it will be in QEMU :) of force > iobase to spec values if device is used as part of a chipset.