On 03/06/2013 06:45 AM, Lei Li wrote: > Signed-off-by: Lei Li <li...@linux.vnet.ibm.com> > --- > qga/commands-win32.c | 28 ++++++++++++++++++++++++++++ > 1 files changed, 28 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index 7e8ecb3..4febec7 100644 > --- a/qga/commands-win32.c > +++ b/qga/commands-win32.c > @@ -22,6 +22,8 @@ > #define SHTDN_REASON_FLAG_PLANNED 0x80000000 > #endif > > +#define _W32_FT_OFFSET (116444736000000000ULL)
Defining a macro with a leading underscore infringes on the namespace
reserved to the system headers and compiler implementation. Drop the
leading underscore.
As written, the () are redundant. However, it would be nicer to state
HOW you came up with this number (and not that you just did a google
search for it), as in:
/* multiple of 100 nanoseconds elapsed between windows baseline
(1/1/1601) and Unix Epoch (1/1/1970), accounting for leap years */
#define W32_FT_OFFSET (10000000ULL * 60 * 60 * 24 * \
(365 * (1970 - 1601) + \
(1970 - 1601) / 4 - 3))
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
