On 07.03.2013 17:09, Paolo Bonzini wrote:
Il 07/03/2013 09:53, Peter Lieven ha scritto:
Then we can add bdrv_revalidate and, for block_resize, call
bdrv_revalidate+bdrv_truncate. For bs->growable = 0 &&
!bs->drv->bdrv_truncate, bdrv_truncate can just check that the actual
size is the same or bigger as the one requested, and fail otherwise.
Regarding brd_drain_all(). Is the fix right to call it only on device
shrink?
I think the fix is to only call it for the monitor command. Optionally,
when shrinking, assert that there are no requests in flight.
Okay.
What is the plan? just fix this or fix the whole thing (which seems to be some
work).
The suggested patch from Jeff will break iscsi_truncate as bs->growable is 1
currently.
Peter
Paolo
In this case it has to be added to iscsi_truncate as well.
