Am 12.03.2013 um 06:01 hat Wenchao Xia geschrieben: > δΊ 2013-3-12 1:49, Eric Blake ει: > >On 03/11/2013 05:23 AM, Wenchao Xia wrote: > >> This patch adds block/snapshot.c and then moves the function > >>there. It also fixes small code style errors reported by check script. > >> > >>Signed-off-by: Wenchao Xia <xiaw...@linux.vnet.ibm.com> > >>--- > >> block/Makefile.objs | 1 + > >> block/snapshot.c | 37 +++++++++++++++++++++++++++++++++++++ > >> include/block/snapshot.h | 26 ++++++++++++++++++++++++++ > >> savevm.c | 23 +---------------------- > >> 4 files changed, 65 insertions(+), 22 deletions(-) > >> create mode 100644 block/snapshot.c > >> create mode 100644 include/block/snapshot.h > > > >>+++ b/block/snapshot.c > >>@@ -0,0 +1,37 @@ > >>+/* > >>+ * Snapshot related functions. > >>+ * > >>+ * Copyright IBM, Corp. 2013 > > > >Technically, since you are moving code from savevm.c, you should also > >preserve the copyright on that moved code: > > > > * Copyright (c) 2003-2008 Fabrice Bellard > > > >>+ * > >>+ * Authors: > >>+ * Wenchao Xia <xiaw...@linux.vnet.ibm.com> > >>+ * > >>+ * This work is licensed under the terms of the GNU LGPL, version 2 or > >>later. > > > >Furthermore, the code you are moving was under BSD license, so by moving > >the code, you have changed its license to something more restrictive. > >Personally, I like LGPL better than BSD, but as I'm not the copyright > >holder of the original code, and neither are you, I'm not sure that > >either of us is qualified to make that change. Therefore, I'm unwilling > >to add my Reviewed-by, even though the code motion itself is correct, > >without a maintainer chiming in on whether your licensing is appropriate > >or needs an adjustment. > > > Oops, Since it belongs to block layer I hope it can be LGPL2. Do you > know how to contact Fabrice Bellard to ask for a change?
Fabrice is not the only copyright owner of this file. Just copy the license as it is, changing licenses is always a nasty thing and as I'm not a lawyer I prefer to stay on the safe side. The MIT license works well enough, there's no real reason to change it. Kevin
