On Thu, Mar 14, 2013 at 11:05:51PM +0800, Lei Li wrote: > This patch series attempts to add Windows implementation > for qemu-ga commands guest-get-time and guest-set-time. > > The previous thread about the interfaces introduced and > the POSIX-specific command implementation has already > been accepted, the reference link: > > http://article.gmane.org/gmane.comp.emulators.qemu/198472 > > Notes: > Now It was tested on Windows XP SP3 and Windows 7. > Please comment!
Series looks good other than comment in patch 1. I can fix this in tree or you can send another version. Reviewed-by: Michael Roth <mdr...@linux.vnet.ibm.com> > > Thanks. > > Changes since v5: > - Fix the error check for GetSystemTime() from Michael. > - Other fixups from Michael. > > Changes since v4: > - Error handel improvement from Michael. > - Do the math explicitly for the time convert of FILETIME > suggested by Michael. > > Changes since v3: > - Reorder the acquire_privilege to avoid a possible > leak of privileges suggested by Eric. > > Changes since v2: > - Overflow check improvement for time_ns from Eric. > > Changes since v1: > - Make the macro for the offset between windows baseline > and Unix Epoch more readable from Eric. > - Overflow check for filetime pointed by Eric. > > Lei Li (2): > qga: add windows implementation for guest-get-time > qga: add windows implementation for guest-set-time >