On 03/09/2013 03:22 PM, Stefan Hajnoczi wrote: > @block-backup > > Start a point-in-time copy of a block device to a new destination. >
Is a BLOCK_JOB_COMPLETED event emitted when the copy is completed? If not, it should be. > +# Since 1.5 > +## > +{ 'command': 'block-backup', > + 'data': { 'device': 'str', 'target': 'str', '*format': 'str', > + '*mode': 'NewImageMode', '*speed': 'int' } } This creates a new job type - do you need to update other locations (such as BlockJobInfo's @type, and in QMP/qmp-events.txt under BLOCK_JOB_CANCELLED/BLOCK_JOB_COMPLETED @type) to call out what string is used for the new job type? For that matter, is it finally time to introduce a new enum type for all valid block job types, and use that enum type instead of 'str' anywhere QMP data structures distinguish based on job type? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature