On 03/18/2013 09:47 PM, Peter Maydell wrote: > >> In preparation for switching to vmstate for migration support, fix >> the sizes of various GIC state fields. In particular, we replace all >> the bitfields (which VMState can't deal with) with straightforward >> uint8_t values which we do bit operations on. (The bitfields made >> >> - unsigned active:NCPU; >> - unsigned level:NCPU; >> - unsigned model:1; /* 0 = N:N, 1 = 1:N */ >> - unsigned trigger:1; /* nonzero = edge triggered. */ >> + uint8_t enabled; >> + uint8_t pending; >> + uint8_t active; >> + uint8_t level; >> + bool model; /* 0 = N:N, 1 = 1:N */ >> + bool trigger; /* nonzero = edge triggered. */ > >
Maybe its worth to use true/false in comments too? Reviewed-by: Igor Mitsyanko <i.mitsya...@gmail.com>
