On 03/26/2013 10:07 AM, Stefan Hajnoczi wrote: > There are several code paths in net_init_socket() depending on how the > socket is created: file descriptor passing, UDP multicast, TCP, or UDP. > Some of these support both listen and connect. > > Not all code paths set the socket to non-blocking. This patch addresses > the file descriptor passing and UDP cases which were missing > socket_set_nonblock(fd) calls. > > I considered moving socket_set_nonblock(fd) to a central location but it > turns out the code paths are different enough to require non-blocking at > different places.
Is it worth rearranging patch 3 first, so that you don't have to churn on these newly-added lines? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
