On Fri, Mar 22, 2013 at 03:23:15PM +0100, Marc-André Lureau wrote:
> Hi,
>
>
> On Mon, Mar 18, 2013 at 2:11 PM, Alon Levy <al...@redhat.com> wrote:
> > + if (atr_protocol_num == 0) {
> > + DPRINTF(s, D_WARN, "%s: error: unimplemented ATR T0 parameters"
> > + " setting\n", __func__);
> > + t0->bmFindexDindex = 0;
> > + t0->bmTCCKST0 = 0;
> > + t0->bGuardTimeT0 = 0;
> > + t0->bWaitingIntegerT0 = 0;
> > + t0->bClockStop = 0;
> > + } else {
> > + if (atr_protocol_num != 1) {
> > + DPRINTF(s, D_WARN, "%s: error: unsupported ATR protocol %d\n",
> > + __func__, atr_protocol_num);
> > + } else {
> > + DPRINTF(s, D_WARN, "%s: error: unimplemented ATR T1 parameters"
> > + " setting\n", __func__);
> > + t1->bmFindexDindex = 0;
> > + t1->bmTCCKST1 = 0;
> > + t1->bGuardTimeT1 = 0;
> > + t1->bWaitingIntegerT1 = 0;
> > + t1->bClockStop = 0;
> > + t1->bIFSC = 0;
> > + t1->bNadValue = 0;
> > + }
> > + }
>
> Those blocks could be at the same indentation level, or perhaps use a switch?
A switch is a good idea.
>
> Is it sensible to warn in all cases?
Turning them into TODO comments instead (except for the now default
case).
>
> --
> Marc-André Lureau
>
