On Tue, Mar 11, 2008 at 11:43:47PM +0100, Fabrice Bellard wrote:
> Aurelien Jarno wrote:
> > Fabrice Bellard a écrit :
> >> IMHO it would be much simpler to do all the tests in the block format
> >> handlers.
> >>
> >
> > Do you mean move all the tests into block-{qcow,qcow2,vmdk}.c ?
>
> I suggest reverting the patch and writing correct tests in
> block-{qcow,qcow2,vmdk}.c. BTW, bs->total_sectors is not a good
> indicator of the device size in case of removable devices for example.
>
I see. I will work on writing a patch asap, probably tomorrow evening.
Aurelien
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' [EMAIL PROTECTED] | [EMAIL PROTECTED]
`- people.debian.org/~aurel32 | www.aurel32.net
