On 3 April 2013 11:32, Paolo Bonzini <pbonz...@redhat.com> wrote: > The alignment is a characteristic of the ABI, not the CPU. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> --- a/target-m68k/cpu.h > +++ b/target-m68k/cpu.h > @@ -21,6 +21,7 @@ > #define CPU_M68K_H > > #define TARGET_LONG_BITS 32 > +#define ABI_INT_ALIGNMENT 2 > > #define CPUArchState struct CPUM68KState I think this define should go in an include file in linux-user/m68k/ -- it's ABI specific and we should be aiming to isolate ABI specific info in linux-user/ rather than having it leaking into target-* and thus into the system emulation code. Otherwise patch looks good. thanks -- PMM