On Mon, 08 Apr 2013 10:02:21 +0800 li guang <lig.f...@cn.fujitsu.com> wrote:
> 在 2013-04-05五的 16:37 +0200,Igor Mammedov写道: > > get_firmware_id() adds possibily for generic code to get guest visible > > CPI id without accessing CPUArchState. If target doesn't override it, > > it will return cpu_index. > > > > Override it on target-i386 to return APIC ID. > > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > --- > > * it will be used later by new cpu_exists() generic function and > > acpi_piix. > > --- > > include/qom/cpu.h | 4 ++-- > > qom/cpu.c | 6 ++++++ > > target-i386/cpu.c | 10 ++++++++++ > > 3 files changed, 18 insertions(+), 2 deletions(-) > > > > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > > index 210aca3..0d33009 100644 > > --- a/include/qom/cpu.h > > +++ b/include/qom/cpu.h > > @@ -46,7 +46,7 @@ typedef struct CPUState CPUState; > > * @reset: Callback to reset the #CPUState to its initial state. > > * @do_interrupt: Callback for interrupt handling. > > * @resume: Callback for putting CPU in runable state > > - * @get_firmware_id: Callback for getting arch depended CPU id > > + * @get_firmware_id: Callback for getting arch depended CPU ID > > get_firmware_id ? > seems obscure to me. > can't it be get_arch_cpuid? *_cpuid might be confused with cpuid term on x86, not sure athe it would be better. Perhaps then get_{arch|}_id() will be sufficient, since it's a method of CPUClass and CPU is implied.