On Mon, Apr 01, 2013 at 04:15:06PM +0800, liu ping fan wrote: > On Thu, Mar 28, 2013 at 10:55 PM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > > > > On Thu, Mar 28, 2013 at 03:55:51PM +0800, Liu Ping Fan wrote: > > It seems the AioContext vs glib issue hasn't been settled yet. My take > > is that glib is preferrable *if* we don't need to write too many > > helpers/wrappers on top (then we're basically back to rolling our own, > > AioContext). > > > > I was surprised by the amount of code required to listen on a file > > descriptor. Are you sure there isn't a glib way of doing this that > > avoids rolling our own GSource? > > > Will diving more into the code, as mdroth's suggestion. Currently the > main issue is that glib seems no support for readalbe or writable.
I mentioned this in another reply. I'm not sure what you mean by glib does not support readable or writeable. It has G_IO_IN and G_IO_OUT for readable/writeable events. > > In the next series, please drop the hub re-entrancy stuff and virtio-net > > data plane. Instead just focus on systematically moving existing net > > clients onto the event loop (net/*.c and NICs). The only controversial > > issue there is AioContext vs glib, and once that's settled we can merge > > the patches. > > > What about the core (queue.c, net.c)? Need I send them out at the > same time or after the backend(clients) convert finished? I think the core changes are necessary to build the converted net clients, so they should be part of the series. Stefan
