On Tue, Apr 09, 2013 at 10:11:37AM +0200, Paolo Bonzini wrote: > Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto: > > Hi liguang, > > > > Just to be curious, how much performance improvement this patch can get? > > I think zero. It is indeed making the code a tiny bit more readable in > the 2nd/3rd/5th/6th hunks.
Then I think the subject should be changed from "optimize" to "readable". "Optimize" is a kind of misleading... > But the 1st and 4th hunks, which do > > - num_insns = 0; > > are wrong. I'm surprised the compiler doesn't report usage of an > uninitialized variable. liguang, how did you test them? > > Paolo > > > > Regards, > > chenwj > -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj