On 9 April 2013 04:04, <mrhi...@linux.vnet.ibm.com> wrote: > From: "Michael R. Hines" <mrhi...@us.ibm.com> > > 1. qemu_file_ops_are() > 2. qemu_file_update_position() (for f->pos) > > Also need to be here: > rdma_read_ops > rdma_write_ops
Do you think you could try to expand on your commit messages a bit? The idea is that a commit message should generally give an overview of the patch including rationale; it should be reasonably meaningful if you look only at the commit message and not the patch itself. This one has a very abbreviated description of the "what" and is missing any kind of "why". thanks -- PMM
