On 04/10/2013 02:51 PM, Corey Bryant wrote:
On 04/02/2013 01:30 PM, Stefan Berger wrote:
return 1;
}
+ /* validate backend specific opts */
+ qemu_opts_validate(opts, be->opts, &errp);
+ if (error_is_set(&errp)) {
+ qerror_report_err(errp);
+ error_free(errp);
+ return 1;
+ }
+
This looks fine to me but I see this is the first call to
qemu_opts_validate() in QEMU. I wonder why.
Well, the function does what is needed here, sorting out command line
parameters that are unknown. It also fits the available parameters.
I fixed the code related to the other comments. Thanks for the review.
Stefan
I