On 15 April 2013 08:29, Peter Chubb <peter.ch...@nicta.com.au> wrote: >>>>>> "Peter" == Peter Maydell <peter.mayd...@linaro.org> writes: > Peter> On 15 April 2013 05:50, Peter Chubb <peter.ch...@nicta.com.au> > Peter> wrote: >>> The problem is a return directive that was removed in the >>> refactoring, so after decoding the instruction, qemu would fall >>> through to do stuff that it should not have done. > > Peter> Nice catch for the ARM decoder, but not needed for thumb2 I > Peter> think? > > It was there in the code that was removed.
No it wasn't, I just looked at the broken commit which is why I pointed it out. (Also you can see that the gen_rfe() above isn't followed by a return, so I checked code flow to be sure it was OK.) thanks -- PMM
