Am 15.04.2013 17:34, schrieb Igor Mammedov: > On Mon, 15 Apr 2013 17:24:36 +0200 > Andreas Färber <afaer...@suse.de> wrote: > >> Am 11.04.2013 16:51, schrieb Igor Mammedov: >>> get_arch_id() adds possibility for generic code to get guest visible >>> CPI id without accessing CPUArchState. If target doesn't override it, >>> it will return cpu_index. >>> >>> Override it on target-i386 to return APIC ID. >>> >>> Signed-off-by: Igor Mammedov <imamm...@redhat.com> >>> --- >>> * it will be used later by new cpu_exists() generic function and >>> acpi_piix. >>> * s/cpu_firmware_id/cpu_arch_id/ >>> --- >>> include/qom/cpu.h | 2 ++ >>> qom/cpu.c | 6 ++++++ >>> target-i386/cpu.c | 10 ++++++++++ >>> 3 files changed, 18 insertions(+) >> >> I'm still unclear about this ID topic, but please don't add QOM methods >> with arch_ in the name. The arch is expressed through subclasses. > > arch is there to explicitly show that returned ID is defined by target and > not generic code. This method then allow to implement cpu_exists() and helps > to init present cpus bitmap in acpi_piix4. > > Would be cpu_id() acceptable?
Certainly. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg