On Mon, 15 Apr 2013 16:57:10 -0300 Eduardo Habkost <ehabk...@redhat.com> wrote:
> On Thu, Apr 11, 2013 at 04:51:43PM +0200, Igor Mammedov wrote: > [...] > > diff --git a/kvm-all.c b/kvm-all.c > > index fc4e17c..1d17128 100644 > > --- a/kvm-all.c > > +++ b/kvm-all.c > > @@ -109,6 +109,7 @@ bool kvm_async_interrupts_allowed; > > bool kvm_irqfds_allowed; > > bool kvm_msi_via_irqfd_allowed; > > bool kvm_gsi_routing_allowed; > > +bool kvm_allowed; > > > > static const KVMCapabilityInfo kvm_required_capabilites[] = { > > KVM_CAP_INFO(USER_MEMORY), > > diff --git a/kvm-stub.c b/kvm-stub.c > > index b34064a..8cb81c4 100644 > > --- a/kvm-stub.c > > +++ b/kvm-stub.c > > @@ -23,6 +23,7 @@ bool kvm_async_interrupts_allowed; > > bool kvm_irqfds_allowed; > > bool kvm_msi_via_irqfd_allowed; > > bool kvm_gsi_routing_allowed; > > +bool kvm_allowed; > > Why do you need kvm_allowed on kvm-stub.c? Isn't simpler and more > efficient to define kvm_enabled() as (0) on CONFIG_USER_ONLY? qom/cpu.o is build only one time for all targets, header ifdef won't work here. > -- > Eduardo -- Regards, Igor