On Fri, Apr 19, 2013 at 11:48:43AM +0800, Fam Zheng wrote: > @@ -1714,6 +1719,11 @@ static QEMUOptionParameter vmdk_create_options[] = { > "VMDK flat extent format, can be one of " > "{monolithicSparse (default) | monolithicFlat | > twoGbMaxExtentSparse | twoGbMaxExtentFlat | streamOptimized} " > }, > + { > + .name = BLOCK_OPT_ZEROED_GRAIN,
This option should be #defined in this patch. > + .type = OPT_FLAG, > + .help = "Enable zeroed-grain featur (implies header.version = 2)" This message doesn't help the user. Maybe something like this? "Enable efficient zero writes using the zeroed-grain GTE feature" I think header.version = 2 isn't relevant to users. People who care will have read the VMDK specification already.