On (Tue) Oct 20 2009 [12:08:06], Richard W.M. Jones wrote:
> On Tue, Oct 20, 2009 at 12:43:44PM +0530, Amit Shah wrote:
> >  DEF("virtioconsole", HAS_ARG, QEMU_OPTION_virtiocon, \
> >      "-virtioconsole c\n" \
> > -    "                set virtio console\n")
> > +    "                define virtio console\n")
> 
> It would be much better to add a detectable string here so we
> (libguestfs) can tell if multiport is supported.  Something like:
> 
>        "                set virtio console (multiport)\n"

How about (deprecated)? (We need to have this in some general policy of
deprecating command-line options.)

> >  STEXI
> >  @item -virtioconsole @var{c}
> >  Set virtio console.
> > +
> > +This option is maintained for backward compatibility.
> > +
> > +Please use @code{-device virtioconsole} for the new way of invocation
> 
> I think you mean -device virtconsole here.

Yeah; thanks. Will fix.

                Amit


Reply via email to