Hi,

This is regarding the Qemu RDMA patch that I co-authored with Michael R
Hines.  Copyright belongs to IBM, and I approve using GPL2 and later.

Jiuxing Liu

----- Forwarded by Bulent Abali/Watson/IBM on 04/18/2013 10:44 AM -----

From:        "Michael S. Tsirkin" <m...@redhat.com>
To:        mrhi...@linux.vnet.ibm.com,
Cc:        qemu-devel@nongnu.org, Bulent Abali/Watson/IBM@IBMUS, Gokul B
Kandiraju/Watson/IBM@IBMUS, Anthony Liguori/Austin/IBM@IBMUS, Michael R
Hines/Watson/IBM@IBMUS, pbonz...@redhat.com, owass...@redhat.com,
quint...@redhat.com
Date:        04/18/2013 04:57 AM
Subject:        Re: [PULL v4 08/11] rdma: core logic
------------------------------



The following comment applies to all of this code:

On Wed, Apr 17, 2013 at 07:07:17PM -0400, mrhi...@linux.vnet.ibm.com wrote:
> diff --git a/migration-rdma.c b/migration-rdma.c
> new file mode 100644
> index 0000000..1dff06f
> --- /dev/null
> +++ b/migration-rdma.c
> @@ -0,0 +1,2667 @@
> +/*
> + *  Copyright (C) 2013 Michael R. Hines <mrhi...@us.ibm.com>
> + *  Copyright (C) 2010 Jiuxing Liu <j...@us.ibm.com>

By the way do you both really hold copyrights on this code?
It's not assigned to IBM?
If the later it should say:
                Copyright IBM
                Author: Michael R. Hines
Or some such.

> + *
> + *  RDMA protocol and interfaces
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License as published by
> + *  the Free Software Foundation; under version 2 of the License.


We prefer 2 or later for new code.
I'm guessing you need approval from Jiuxing Liu for this,
pls make him ack license change.

> + *
> + *  This program is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with this program; if not, see <http://www.gnu.org/licenses/>.
> + */

Reply via email to