-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 22/04/2013 17:00, Eric Blake ha scritto: > On 04/22/2013 06:07 AM, Paolo Bonzini wrote: >> Il 22/04/2013 13:48, Amos Kong ha scritto: >>>>>>> Libvirt doesn't have a stable way to know option >>>>>>> support detail. This patch introdued a new qmp command >>>>>>> to query configuration schema information. hmp command >>>>>>> isn't added. >>>>> >>>>> Can you introspect QemuOpts instead? All new options are >>>>> added there. >>> >>> It would be exact to use QemuOpts. I tried to output the >>> vm_config_groups[] in qemu-config.c, but it seems not enough. >>> (desc list of -netdev, -drive, -device are all empty) >> >> That's expected because they are parsed otherwise, depending on >> the backend type. -chardev is currently working but it's an >> implementation detail. > > Libvirt cares most about newly added options, which should use > qemuOpts all the way. We can understand that legacy options like > -netdev might not yet use qemuOpts, but they are also legacy > options, and therefore libvirt can already assume they exist since > at least qemu 1.3 (when libvirt switched over to QMP probing). If > we later add a new feature to -netdev, we should also convert > -netdev to qemuOpts at that time, so that libvirt would know > whether the new feature is available.
- -netdev is not a legacy option. -netdev/-drive/-device do use QemuOpts, but not for validation. They create an object, and let the object parse the option. They are more complex than the other option, and need a different kind of introspection (on the properties of a class, or something like that). Paolo > At any rate, we really DO want introspection, and having it in 1.5 > is a worthwhile goal. Even if the introspection turns up empty on > legacy options, having it for the sake of new options is worth the > effort. > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRdVQyAAoJEBvWZb6bTYbyopcP/jE5TX/NziMeXmXmSS+GFn4G 4SH+4XckjZZPe2ZnpshvkWi1OrbsK0CKw9nk4xcZRFmUFnIZ4T1J2VBXodnATvKZ +r6yqvOCuoleWQBlnN8OJm/I5kil5UkztiUSsDbgYyP2D4pr3Z7+uGX7ju/4oGCK qEASGYRsGFItvKkjfUDL2UjBv3dnDerWSPj9IsD/sFajGqcBrvfbGK8YeOG7YvQF Tinv5dhHg9dpnTJ/fwmw0xr3BmgzLf4fT16I73ErG1INOBjWSUPkQ0h8UeydJEJq nvpj3/zlqqJdSNxZXU1FRP+stQN2hHDZsTXhKuY+2kbDFRqpwB8WG94TEbOdx6gr fyNHfueWIByylmQNgbvBCyR2hVI+RipgGHfQ6slTcMMu2pZpZ1m9vWfZF8bvAS+p NL4+Rf+Ic4uMKZnS6GvD15px0ugGPIcDdwX7YgVqjNMIRZhKFiOf9HYnUfJstQpN WrEpcnyE4p0JzkO27Otezoz+RTpJ8HaKHvnsbM49BDlWDMme7jKveymWnCyeJxib g7Hz7V7M76LK0Mlcn66PYctF6JVZP25hC3p3poYbm2F9Duvwg78+b53O6k1XN0sP /kuZfYWrWRr6sx+/oN6HWMP5q60jRVYKUOYcNOriWS+6Yi8xohFvqQVu4qmycXOG 3HBqamagi+JNMiiO9cx/ =4p7B -----END PGP SIGNATURE-----
