On Tue, Apr 23, 2013 at 03:43:51PM +0200, Juan Quintela wrote: > Igor Mammedov <imamm...@redhat.com> wrote: > > * introduce processor status bitmask visible to guest at 0xaf00 addr, > > where ACPI asl code expects it > > * set bit corresponding to APIC ID in processor status bitmask on > > receiving CPU hot-plug notification > > * trigger CPU hot-plug SCI, to notify guest about CPU hot-plug event > > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > This is wrong (or at least supperfluous) > > > +static int piix4_init_cpu_status(Object *obj, void *opaque) > > +{ > > + struct cpu_status *g = (struct cpu_status *)opaque; > > + Object *cpu_obj = object_dynamic_cast(obj, TYPE_CPU); > > + > > + if (cpu_obj) { > > + struct Error *error = NULL; > > we set error to NULL > > > + CPUClass *k = CPU_GET_CLASS(cpu_obj); > > + int64_t id = k->get_arch_id(CPU(cpu_obj)); > > + > > + if (error) { > > and without touching error we test if it is != NULL. > > > something is missing here?
Looks like a leftover from v1, that called object_property_get_int() (with an error argument) instead of k->get_arch_id(). -- Eduardo