On Wed, Apr 24, 2013 at 02:31:27PM +0200, Stefan Hajnoczi wrote: > On Tue, Apr 23, 2013 at 10:24:21AM -0400, Jeff Cody wrote: > > +/* ---- HEADER SECTION STRUCTURES ---- */ > > + > > +/* Important note: these structures are as defined in the VHDX > > specification, > > + * including byte order and size. However, without being packed > > structures, > > + * they will not match 1:1 data read from disk. Rather than use > > potentially > > + * non-portable packed structures, data is copied from read buffers into > > + * the structures below. However, for reference, please refrain from > > + * modifying these structures to something that does not represent the > > spec */ > > Outdated comment? The patch uses QEMU_PACKED. >
Yes, outdated comment, thanks. > > +/* Header for the region table block */ > > +#define VHDX_RT_MAGIC 0x69676572 /* 'regi ' */ > > Not worth respinnning, but should be 'regi' (4 bytes). Per Kevin's comments, I am removing all the _MAGIC's from the headers anyway, and using memcmp against the strings in the source file. So I'll take care of the outdated comment as well then.
