On 04/24/2013 10:57 PM, Eric Blake wrote:
On 04/24/2013 04:12 AM, Lei Li wrote:
Signed-off-by: Lei Li <li...@linux.vnet.ibm.com>
---
  docs/vnc-ledstate-Pseudo-encoding.txt |   40 +++++++++++++++++++++++++++++++++
  1 files changed, 40 insertions(+), 0 deletions(-)
  create mode 100644 docs/vnc-ledstate-Pseudo-encoding.txt

+
+The Pseudo-encoding number for LED state defined as:
+
+======= ===============================================================
+Number  Name
+======= ===============================================================
+-261    'LED state Pseudo-encoding'_
Is the trailing _ intentional?

Yes, add this trailing '_' to indicate that this is a quoted context and you can
locate its section somewhere.
I saw this style used in RFB protocol, but it's not necessary. I'd get rid of it
if you don't like it. :)


+======= ===============================================================
+
+LED state Pseudo-enconding
s/enconding/encoding/

Sure.

+--------------------------
+
+The LED state Pseudo-encoding describes the encoding of LED state which
+consists of 3 bits, each bit represents the Caps, Num, and Scroll lock
+key respectively. '1' indicates that the LED should be on and '0' should
+be off.
Which bit is which?  Is bit 0 the Caps lock LED?

Caps lock key is represented as '100', and Scroll lock key is represented as 
'001'.
Sorry, I should describe it more clearly.
Or maybe I should include the example of the encodings defined?




--
Lei


Reply via email to