On 04/25/2013 06:37 PM, MORITA Kazutaka wrote: > +/* update inode with the latest state */ > +static int coroutine_fn reload_vdi_object(BDRVSheepdogState *s)
I'd suggest function name as 'reload_inode(BDRVSheepdogState *s, tag, snapid)', then sd_create_branch and sd_snapshot_goto can make use of this function. With this change, it would be conflicted to my patch series applied to Stefan's block tree + Fix loadvm patch. So it would be better you can develop this patch set against Stefan's block tree + my fix loadvm patch. Others looks good to me. Thanks, Yuan