On Wed, Apr 24, 2013 at 05:31:58PM +0200, Pavel Hrdina wrote: > I'm sending patches for all commands in one patch series because the > savevm command depends on delvm command. > > This patch series introduces new design of these commands: > > * QMP vm-snapshot-save: > - { 'command': 'vm-snapshot-save', > 'data': { 'name': 'str' }, > 'returns': 'SnapshotInfo' } > - vm-snapshot-save returns an error if there is an existing snapshot with > the same name > - you cannot provide an id for a new snapshot > - all information about created snapshot will be returned > > * QMP vm-snapshot-load > - { 'command': 'vm-snapshot-load', > 'data': { '*name': 'str', '*id': 'str' }, > 'returns': 'SnapshotInfo' } > - one of the name or id must be provided > - if both are provided they will match only the snapshot with the same > name > and id > - returns SnapshotInfo only if the snapshot exists. > > * QMP vm-snapshot-delete: > - { 'command': 'vm-snapshot-delete', > 'data': { '*name': 'str', '*id': 'str' }, > 'returns': 'SnapshotInfo' } > - same rules as vm-snapshot-load
If I cannot specify the id when creating the snapshot, then why can I provide it when loading/deleting? In other words, is it useful to support the id arguments? If yes, please include the reason in the API documentation.