On 04/19/2013 11:47 AM, Luiz Capitulino wrote: > Commit 9ca111544c64b5abed2e79cf52e19a8f227b347b moved the call to > bdrv_dev_change_media_cb() outside the media check in bdrv_close(), > this added a regression where spurious DEVICE_TRAY_MOVED events > are emitted at shutdown.
Libvirt can tolerate the extra events, but I agree that targeting 1.5 as the release to clean this back up is reasonable. > > To fix that this commit moves the bdrv_dev_change_media_cb() calls > to the callers that really need to report a media change, which > are eject_device() and do_drive_del(). This fixes the problem > commit 9ca1115 intended to fix, plus the spurious events. > > Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com> > --- > block.c | 2 -- > blockdev.c | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
